Skip to content

Adding ACL scope to reminder remove #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
semper-lux merged 2 commits into from
Oct 24, 2025
Merged

Adding ACL scope to reminder remove #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
726e98a
Adding ACL scope to reminder remove
semper-lux Oct 24, 2025
b57f0cf
Updated comment following reviewer suggestion
semper-lux Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/reminders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from sqlalchemy.orm import Mapped, mapped_column
from sqlalchemy.sql.functions import current_timestamp

from bot.acl import privileged
from bot.acl import EvalResult, evaluate_ctx, privileged, register_action
from bot.client import client
from bot.commands import Context, cleanup, plugin_command
from bot.tasks import task
Expand Down Expand Up @@ -44,6 +44,7 @@ def __init__(


logger = logging.getLogger(__name__)
manage_reminders = register_action("manage_reminders") # For use in removing reminders


def format_msg(guild_id: int, channel_id: int, msg_id: int) -> str:
Expand Down Expand Up @@ -191,6 +192,10 @@ async def reminder_remove(ctx: Context, id: int) -> None:
"""Delete a reminder."""
async with sessionmaker() as session:
if reminder := await session.get(Reminder, id):
# To remove another user's reminders you need elevated permissions
if reminder.user_id != ctx.author.id:
if manage_reminders.evaluate(*evaluate_ctx(ctx)) != EvalResult.TRUE:
raise UserError("Reminder {} is owned by a different user.".format(id))
await session.delete(reminder)
await session.commit()
await ctx.send(
Expand Down