-
Notifications
You must be signed in to change notification settings - Fork 9
chore[hosting]: use docker for hosting #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now that we have a dockerfile, one of our supported hosting platforms will use that file for running the bot, and will ignore the Procfile This means that we can switch the process type back to worker, which is what our other supported hosting platform is expecting.
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 35.49% 35.49%
=======================================
Files 12 12
Lines 555 555
Branches 64 64
=======================================
Hits 197 197
Misses 352 352
Partials 6 6 Continue to review full report at Codecov.
|
|
@onerandomusername have you tested this on our providers? |
|
Yes, this resets it to what it was in commit ff75614 |
|
Ok |
|
We could add a heroku.yml file in order to build a docker container on heroku as well. Perhaps we should do that, which would hopefully let us remove requirements.txt in a future pr, provided every integration works after this is merged. |
|
I've managed to set up a heroku.yml file, which now means that heroku will deploy by creating a docker image, This needs to be tested by deploying to heroku. |
|
Testing if I can make this project deploy, and then we should be good to go. |
dawnofmidnight
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot deploy to Heroku at the moment, but everything looks good.
Now that we have a dockerfile, one of our supported hosting platforms will use that file for running the bot, and will ignore the Procfile. This means that we can switch the process type back to worker, which is what our other supported hosting platform is expecting.