Skip to content

Conversation

@onerandomusername
Copy link
Contributor

@onerandomusername onerandomusername commented Aug 19, 2021

Now that we have a dockerfile, one of our supported hosting platforms will use that file for running the bot, and will ignore the Procfile. This means that we can switch the process type back to worker, which is what our other supported hosting platform is expecting.

Now that we have a dockerfile, one of our supported hosting platforms
will use that file for running the bot, and will ignore the Procfile
This means that we can switch the process type back to worker, which is
what our other supported hosting platform is expecting.
@onerandomusername onerandomusername self-assigned this Aug 19, 2021
@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #58 (0d36e6e) into main (de403fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   35.49%   35.49%           
=======================================
  Files          12       12           
  Lines         555      555           
  Branches       64       64           
=======================================
  Hits          197      197           
  Misses        352      352           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de403fd...0d36e6e. Read the comment docs.

@onerandomusername onerandomusername added p: normal Normal Priority s: approved The issue has received a maintainer's approval s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request t: chore Maintainence fix labels Aug 19, 2021
@onerandomusername onerandomusername requested a review from a team August 19, 2021 05:11
@bast0006
Copy link
Collaborator

@onerandomusername have you tested this on our providers?

@onerandomusername
Copy link
Contributor Author

Yes, this resets it to what it was in commit ff75614

@bast0006
Copy link
Collaborator

Ok

@onerandomusername
Copy link
Contributor Author

We could add a heroku.yml file in order to build a docker container on heroku as well. Perhaps we should do that, which would hopefully let us remove requirements.txt in a future pr, provided every integration works after this is merged.

@onerandomusername onerandomusername marked this pull request as draft August 19, 2021 16:09
@onerandomusername
Copy link
Contributor Author

I've managed to set up a heroku.yml file, which now means that heroku will deploy by creating a docker image,
however, I had to run heroku stack:set container on the application, so I ended up making an app.json file.

This needs to be tested by deploying to heroku.

@onerandomusername
Copy link
Contributor Author

Testing if I can make this project deploy, and then we should be good to go.

@onerandomusername onerandomusername marked this pull request as ready for review August 19, 2021 17:45
@bast0006 bast0006 enabled auto-merge August 19, 2021 17:56
@bast0006 bast0006 disabled auto-merge August 19, 2021 17:56
Copy link
Contributor

@dawnofmidnight dawnofmidnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot deploy to Heroku at the moment, but everything looks good.

@dawnofmidnight dawnofmidnight changed the title chore[hosting]: switch process type back to worker chore[hosting]: use docker for hosting Aug 19, 2021
@onerandomusername onerandomusername removed the skip changelog Skip the need for a changelog entry for a Pull Request label Aug 19, 2021
@onerandomusername onerandomusername merged commit 2038e8c into main Aug 19, 2021
@onerandomusername onerandomusername deleted the chore/update-procfile branch August 19, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: normal Normal Priority s: approved The issue has received a maintainer's approval s: needs review Ready for review and merge t: chore Maintainence fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants