Skip to content

Conversation

@onerandomusername
Copy link
Contributor

No description provided.

@onerandomusername onerandomusername added p: high High Priority a: tools Development related to our toolchain (Docker, poetry, flake8) s: needs review Ready for review and merge labels Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #70 (1537a5c) into main (d7c41b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   38.62%   38.62%           
=======================================
  Files          16       16           
  Lines         769      769           
  Branches      105      105           
=======================================
  Hits          297      297           
  Misses        459      459           
  Partials       13       13           
Impacted Files Coverage Δ
modmail/__init__.py 100.00% <ø> (ø)
modmail/__main__.py 56.25% <ø> (ø)
modmail/bot.py 33.33% <ø> (ø)
modmail/config.py 96.92% <ø> (ø)
modmail/extensions/extension_manager.py 0.00% <ø> (ø)
modmail/extensions/meta.py 0.00% <ø> (ø)
modmail/extensions/plugin_manager.py 0.00% <ø> (ø)
modmail/extensions/utils/paginator_manager.py 0.00% <ø> (ø)
modmail/plugin_helpers.py 0.00% <ø> (ø)
modmail/utils/embeds.py 93.93% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c41b6...1537a5c. Read the comment docs.

@Shivansh-007
Copy link
Member

Changelog this.

@onerandomusername
Copy link
Contributor Author

Not worth a changelog, none of this is user facing.

@onerandomusername onerandomusername added the skip changelog Skip the need for a changelog entry for a Pull Request label Sep 1, 2021
@bast0006
Copy link
Collaborator

bast0006 commented Sep 4, 2021

Honestly, we should still changelog this, if only for ourselves

Copy link
Collaborator

@bast0006 bast0006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright... but this is gonna really shake things up a bit. Not sure how the final merge is going to be, but hopefully not too bad for all the other prs.

@onerandomusername onerandomusername merged commit 0ed105f into main Sep 5, 2021
@onerandomusername onerandomusername deleted the chore/fix-up-imports branch September 5, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tools Development related to our toolchain (Docker, poetry, flake8) p: high High Priority s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants