Skip to content

Conversation

@afgiel
Copy link
Contributor

@afgiel afgiel commented Jul 11, 2024

had a partner ask about the valid options for level, figured it would be good to document

@afgiel afgiel requested a review from colinloretz July 11, 2024 16:17
@advaith1
Copy link
Contributor

is there a point in the effect column here? we could just list them out if we don't have any actual information warranting a table

Copy link
Contributor

@matthova matthova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Per @advaith1 I get that the table is a bit redundant, but 🤷🏻 however we call it out works.

@afgiel afgiel merged commit 7b5cc9a into main Jul 11, 2024
@afgiel afgiel deleted the afgiel/capture-log-level branch July 11, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants