Accessibility: wrap <li> elements in <ul> #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @discoursehosting This PR was submitted to hnb-ku/discourse-custom-header-links. We've since transferred that repository over to discourse/discourse-custom-header-links. Due to the complications of syncing the two repositories, I was not able to merge your PR but I added a fix in #3. The repository's permanent home is discourse/discourse-custom-header-links so any future PRs you send there will retain your name as a contributor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility audit results complained about the li elements not being wrapped in an ul element.
This was confusing screen reading software.