-
Notifications
You must be signed in to change notification settings - Fork 1
FEATURE: Add new metrics #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
martin-brennan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice to add specs for each report too, doesn't have to be crazy but I think it will be necessary if we want to evolve this plugin into something used every year + more widely rather than just an experiment. I am trying to backfill specs for the old reports over at #21
| # Shows message counts, favorite channels, DM activity, etc. | ||
| module DiscourseRewind | ||
| module Action | ||
| class ChatUsage < BaseReport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing with this report, is that it may be pretty underwhelming depending on a site's chat_channel_retention_days setting. It defaults to 90 days, so will only be the last 3 months for public channels.
For DMs it's better chat_dm_retention_days is infinite by default, but people can set it lower.
So yeah not sure what the strategy of dealing with this would be, it just might be confusing to say this is your year of messages + favourite channels when someone might have set retention to 2 weeks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the design from @awesomerobot can say, "Recent Chat Activity" ?
| gif_usage | ||
| end | ||
|
|
||
| def extract_gifs_from_chat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment about chat potentially not having much meaningful data
| # Determines if they are a night owl or early bird | ||
| module DiscourseRewind | ||
| module Action | ||
| class TimeOfDayActivity < BaseReport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe one more threshold could be fun is HIGH_NOONERS_THRESHOLD that goes from 12pm-3pm or something?
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Co-authored-by: Martin Brennan <mjrbrennan@gmail.com>
Add the following reports: