Skip to content

Conversation

@martin-brennan
Copy link
Contributor

@martin-brennan martin-brennan commented Nov 6, 2025

This was confusing people last year, most people assumed it meant
the tags they used the most / categories they posted in the most.
This should clear things up.

Also removes the isRewindActive function in favour of is_rewind_active
on the current user, since then we only have one place to check this, and
it makes testing easier since we don't have to mock browser time.

Finally it moves the route for rewind in the UI to the new route path format.

This was confusing people last year, most people assumed it meant
the tags they used the most / categories they posted in the most.
This should clear things up.
@martin-brennan martin-brennan force-pushed the ux/favorite-tags-categories branch from 62f16c6 to 0c0229e Compare November 6, 2025 02:25
@martin-brennan martin-brennan force-pushed the ux/favorite-tags-categories branch from cb03156 to 3101879 Compare November 6, 2025 03:41
@martin-brennan martin-brennan changed the title UX: Rename Favorite Tags/Categories to Most Viewed Tags/Categories FIX: Rename Favorite Tags/Categories to Most Viewed Tags/Categories and isRewindActive fixes Nov 6, 2025
This makes it only one place to check if Rewind is active
on the frontend, and it makes it easier to test since we don't
have to mock the browser time etc.
@martin-brennan martin-brennan force-pushed the ux/favorite-tags-categories branch from 1df1eb8 to 31b447c Compare November 6, 2025 04:05
Copy link
Contributor

@jjaffeux jjaffeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLGSTM: looks like good soup to me

@martin-brennan martin-brennan merged commit a600db4 into main Nov 7, 2025
4 checks passed
@martin-brennan martin-brennan deleted the ux/favorite-tags-categories branch November 7, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants