-
Notifications
You must be signed in to change notification settings - Fork 1
UX: restyling for 2025 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| height: 125px; | ||
| } | ||
|
|
||
| &:nth-child(1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these images from? Do we have to credit anyone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're Windows 3.1 solitaire card backs that someone recreated and made freely available on https://kidmarscat.itch.io/solitaire... Microsoft still likely owns the rights to those designs, so I guess it would be safer to replace them with something more explicitly free... I'll look into that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah I remember now! Does seem like they would still own these sadly, but I do wonder how much it would matter...there is this thing in the steam workshop that uses them for example https://steamcommunity.com/sharedfiles/filedetails/?id=262705418 . But yeah probably safer to have something free.
martin-brennan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks for adding some stuff to make it easier to test locally too. This let me notice some issues with posts/topics that we were discussing in the internal PM too, I will fix in a separate PR
* Use post excerpt for best posts to avoid giant posts ruining it * Make sure short emojis (e.g. 😂) render in best posts and best topics * Make images show in best post excerpts (requires core change) * Fix invite action error, using column that doesn't exist * Add missing # for top category slugs * Refactor report service + controller a little to make it easier to figure out what went wrong if it fails, and to use the guardian user Copies a couple of fixes from #28 to make things work locally, the conflicts will be easy to resolve.
* Use post excerpt for best posts to avoid giant posts ruining it * Make sure short emojis (e.g. 😂) render in best posts and best topics * Make images show in best post excerpts (requires core change) * Fix invite action error, using column that doesn't exist * Add missing # for top category slugs * Refactor report service + controller a little to make it easier to figure out what went wrong if it fails, and to use the guardian user Copies a couple of fixes from #28 to make things work locally, the conflicts will be easy to resolve.
* Use post excerpt for best posts to avoid giant posts ruining it * Make sure short emojis (e.g. `:joy:`) render in best posts and best topics * Make images show in best post excerpts (requires core change) * Fix invite action error, using column that doesn't exist * Add missing # for top category slugs * Refactor report service + controller a little to make it easier to figure out what went wrong if it fails, and to use the guardian user Copies a couple of fixes from #28 to make things work locally, the conflicts will be easy to resolve. **Best topics before** <img width="977" height="712" alt="image" src="https://github.com/user-attachments/assets/e120507f-d0d8-44f0-b242-e1056084ef03" /> **Best topics after** <img width="969" height="648" alt="image" src="https://github.com/user-attachments/assets/dd13f6ac-35df-4e9a-907e-9ed5102843b6" /> **Categories before** <img width="904" height="465" alt="image" src="https://github.com/user-attachments/assets/0d15e73d-3534-4836-b776-2c97381e58ef" /> **Categories after** <img width="925" height="466" alt="image" src="https://github.com/user-attachments/assets/3d6e4eae-32ed-4f11-a4f4-090e4473ebe9" />
This generally updates the styles for the 2025 version. I also made more features work in development environments (so it's easier to test) and fixed an issue with invites that was causing the report to not show.