FIX: Prevent left-over markup for old hidden post notices #35311
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor `PostNotice` rendering logic into a static `shouldRender` method, centralizing eligibility checks and improving code clarity. Update the parent component to use this method, ensuring old hidden post notices are no longer rendered and the parent row is not rendered in the post content.
chapoi
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
PostNoticerendering logic into a staticshouldRendermethod, centralizing eligibility checks and improving code clarity. Update the parent component to use this method, ensuring old hidden post notices are no longer rendered including the parent row in the post component.