Parameterize filenames #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featheredtoast
added a commit
to featheredtoast/discourse-launcher-extras
that referenced
this pull request
Nov 16, 2024
use parameterized config filenames. needed for multi container builds on docker compose depends on discourse/launcher#2 to be merged first for parameterization
featheredtoast
added a commit
to featheredtoast/discourse-launcher-extras
that referenced
this pull request
Nov 16, 2024
use parameterized config filenames. needed for multi container builds on docker compose depends on discourse/launcher#2 to be merged first for parameterization
featheredtoast
added a commit
to featheredtoast/discourse-launcher-extras
that referenced
this pull request
Nov 16, 2024
use parameterized config filenames. needed for multi container builds on docker compose depends on discourse/launcher#2 to be merged first for parameterization
Parameterize which filename to write to (write config) and which file is copied from (dockerfile) Allows for external apps to control which filenames the config writes to, so multiple configuration files and dockerfiles can be written to the same path without conflict.
featheredtoast
force-pushed
the
parameterize-config-filename
branch
from
5584e18 to
7671dc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameterize which filename to write to (write config) and which file is copied from (dockerfile)
Allows for external apps to control which filenames the config writes to, so multiple configuration files and dockerfiles can be written to the same path without conflict.