Skip to content

PCP Update #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maxusmusti wants to merge 19 commits into from
Closed

PCP Update #1956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
23b7691
PCP update 1
Maxusmusti Oct 22, 2020
c59fd33
Completed original (will remove htd)
Maxusmusti Oct 29, 2020
53c9084
Bug fixes round 1
Maxusmusti Oct 29, 2020
75b305b
Bugfixes part 1.5
Maxusmusti Oct 31, 2020
11edd53
Bugfixes 2.0
Maxusmusti Oct 31, 2020
c8c623c
Bugfixes 2.5
Maxusmusti Oct 31, 2020
d146a73
Debugging part 3-ish
Maxusmusti Nov 2, 2020
87c4bcb
Should now work when not registered
Maxusmusti Nov 2, 2020
5a39a06
typo fix
Maxusmusti Nov 2, 2020
56a6120
WAIT it's actually kinda working
Maxusmusti Nov 5, 2020
633559b
Cleanup misleading error logs and some unnecessary vars
Maxusmusti Nov 5, 2020
63c5b0e
Flake8 and Black changes
Maxusmusti Nov 5, 2020
2082362
TM error removal
Maxusmusti Nov 6, 2020
a580a03
TDS remove errors
Maxusmusti Nov 6, 2020
93c62ba
Remove extra redis upload part 1
Maxusmusti Nov 7, 2020
174f692
typo fixes
Maxusmusti Nov 7, 2020
1a727aa
Remove redis upload pt2
Maxusmusti Nov 7, 2020
a2a838d
Using new performancecopilot.metrics collection on galaxy
Maxusmusti Nov 11, 2020
36b79f8
Fixed broken ansible run
Maxusmusti Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion agent/tool-scripts/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@

"persistent":{
"node-exporter": {"collector": "prometheus", "port": "9100"},
"dcgm": {"collector": "prometheus", "port": "8000"}
"dcgm": {"collector": "prometheus", "port": "8000"},
"pcptool": {"collector": "pcp", "port": "44321"}
Copy link
Member

@portante portante Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the existing pcp tool entirely, and just replace it with this one.

}
}
25 changes: 25 additions & 0 deletions agent/tool-scripts/pcptool
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#!/usr/bin/python3
# -*- mode: python -*-

import sys
import os
import logging

PROG = os.path.basename(sys.argv[0])
logger = logging.getLogger(PROG)
logger.setLevel(logging.DEBUG)
sh = logging.StreamHandler()
sh.setLevel(logging.DEBUG)
shf = logging.Formatter("%(message)s")
sh.setFormatter(shf)
logger.addHandler(sh)

if len(sys.argv) != 2 or sys.argv[1] != "--help":
logger.info("This script is deprecated, please run it with --help for info on registering the tool.")
logger.info("Run /opt/pbench-agent/tool-scripts/pcptool --help for more info.")
exit(0)

if sys.argv[1] == "--help":
logger.info("Options:")
logger.info("--inst=<LOCATION OF pcptool INSTALL> (required)")

Loading