-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Exclude model base classes (MTI or otherwise) from warnings #3611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Failed builds due to lack of StringIO module in Python 3.x. This is actually an issue in the related PR #3613, which this PR depends on. |
|
@mkoistinen get StringIO from the six package bundled in Django |
|
@yakky, fixed issues with Python 3.x. Now, as predicted, issues with Django 1.7. In this case, because the test runner is attempting to inherit from a model with different migration type. Help? |
|
@mkoistinen can you remove the changes to develop.py and integrate the django 1.7 migrations ? |
|
Done! |
These will be in django-cms#3613
|
Just rebased it to current support/3.0.x |
|
👍 waiting for tests to complete |
develop.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now useless, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, removed.
On Sun, Jan 11, 2015 at 11:20 PM, Iacopo Spalletti <notifications@github.com
wrote:
In develop.py
#3611 (diff):@@ -189,40 +208,62 @@ def shell():
call_command('shell')+class capture_all_output(object):
This is now useless, right?
Reply to this email directly or view it on GitHub
https://github.com/divio/django-cms/pull/3611/files#r22770187.
MARTIN KOISTINEN
BG GSM +359 878 787 253UK GSM +44 7703 046 154
UK VoIP +44 20 3286 9932
_US VoIP +1 (__678) _389-6676
100% CARBON-NEUTRAL SINCE 1-JAN-2008
Fixes #3604