Fixed plugin ordering for live plugins. #3661
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #3637 When publishing a page, the draft plugins are copied to new 'live' versions of themselves. The code was incorrectly overwriting the position of the plugins. This change means the position remains identical to the position of the draft plugin, which is the only correct value.
Merged
yakky
added a commit
that referenced
this pull request
Feb 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3637
When publishing a page, the draft plugins are copied to new 'live' versions of themselves. The code was incorrectly overwriting the position of the plugins. This change means the position remains identical to the position of the draft plugin, which is the only correct value.
This pull request is incomplete because it lacks a test case demonstrating that the issue exists as well as proving that this change fixes it. I've had challenges getting a test case to exercise the appropriate code paths since setting up the test data appears to require front-end editing and can't be triggered via the api as the current
test_plugin_orderdoes.