Skip to content

Conversation

@jmgilman
Copy link
Collaborator

@jmgilman jmgilman commented Oct 7, 2022

This PR introduces support for generating container images that are compatible with devcontainers. It ingests a devshell and builds a compatible OCI image which can then be invoked as a devcontainer.

@jmgilman jmgilman marked this pull request as draft October 7, 2022 00:56
@blaggacao
Copy link
Collaborator

blaggacao commented Oct 7, 2022

/cc @angerman fyi/fysa

@jmgilman
Copy link
Collaborator Author

jmgilman commented Oct 7, 2022

The last commit was done entirely within the devcontainer for std! 🚀

@jmgilman
Copy link
Collaborator Author

jmgilman commented Oct 7, 2022

The function has been generalized so as to not rely on vscode. By default, it creates a "generic" container which can be used like so:

docker run -it -v "$(pwd):/work" --entrypoint /bin/bash std-dev

If the vscode argument is set to true, then it will augment the container to be compatible with vscode:

devcontainer open .

@jmgilman jmgilman marked this pull request as ready for review October 7, 2022 22:23
Copy link
Collaborator

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minors...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants