Skip to content

Conversation

@fsbraun
Copy link
Member

@fsbraun fsbraun commented Oct 23, 2025

Fix tab layout in small modals by adding flex-wrap to nav-pills and updating the compiled CSS

Fixes #318

Bug Fixes:

  • Enable flex-wrap on nav-pills to prevent tabs from breaking in narrow modals

Build:

  • Regenerate compiled base.css after SASS update

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request patches the tab layout in narrow modal windows by enabling wrapping for the tab list and updating the compiled CSS accordingly.

File-Level Changes

Change Details Files
Enable wrapping on tab list to prevent overflow in small modals
  • Added flex-wrap: wrap to the SASS rule for .nav-pills tabs
  • Recompiled base.css to include the updated layout behavior
private/sass/components/_tabs.scss
djangocms_frontend/static/djangocms_frontend/css/base.css

Assessment against linked issues

Issue Objective Addressed Explanation
#318 Prevent tab titles with spaces from breaking into two lines and overflowing their border boxes in the plugin modal.
#318 Ensure that when the tab list grows longer than the modal width, the layout adapts (e.g., by spreading tabs into two rows or enabling horizontal scrolling) to maintain usability and visual integrity.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (ce49f00) to head (d779687).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files         124      124           
  Lines        3387     3387           
  Branches      288      288           
=======================================
  Hits         3019     3019           
  Misses        252      252           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fsbraun fsbraun merged commit 8eb0431 into main Oct 23, 2025
33 of 34 checks passed
@fsbraun fsbraun deleted the fix/tab-wrap branch November 19, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin tab titles with spaces do not break correctly

2 participants