Added package.json file to maintain axe-core dependency #129
Conversation
* added package.json to manage axe-core updates more easily * updated setup.py and MANIFEST.in to include new axe.js file, and the sample page for test * adding pypi deployment to travis * moved changelog into readme to fix file not found error
kimberlythegeek
requested review from
davehunt and
m8ttyB
and removed request for
m8ttyB
davehunt
left a comment
davehunt
left a comment
There was a problem hiding this comment.
Is it intentional to add node_modules? I'm not familiar with best practices for node, but this seems unusual.
|
@davehunt When the travis builds ran without it, the tests failed, because the axe-core javascript file was missing. I don't know exactly how to install npm dependencies and make sure they are in the correct directory. I'll look into it again this morning. |
|
Ah, maybe add an |
|
@davehunt I attempted to do that, but I really don't know enough about Docker. I'll have to read more documentation and give it another try. Too bad we're missing our Docker person :) |
|
Oh right, this is in Docker. Can you add node and the install command to the Docker image instead? |
kimberlythegeek
force-pushed
the
npm_dependency
branch
from
afe2f3d to
8e76b8d
Compare
* run tests without docker * updating travis config * removing chrome tests * updating geckodriver
* removed some badges from readme"
m8ttyB
left a comment
m8ttyB
left a comment
There was a problem hiding this comment.
lgtm based off of the build passing (-:
3 participants
Will use npm to keep axe-core up to date, rather than doing so manually
fixed password hash for travis pypi deployment
moved changelog into readme to avoid file not found error