Feature/execute script asyncronously #141
Conversation
neverstew
force-pushed
the
feature/execute-script-asyncronously
branch
from
cabc7b0 to
b57b793
Compare
|
@stephendonner / @kimberlythegeek / other contributors - got a chance to get this working locally but just struggling to get the chromedriver set up on travis. If anyone gets the chance to have a look that would be fantastic. |
neverstew
force-pushed
the
feature/execute-script-asyncronously
branch
from
041e69c to
ff73b0a
Compare
|
@moz-hwine - can an admin get to this any time soon? |
|
@matt-l-w Hi! First I want to say that I really appreciate your contribution! 😄 Also, my apologies for the delay, I was on leave last week. I will look over this today or tomorrow. Currently trying to get caught up on emails, and everything else 🙂 |
|
No worries! Hope the break was good 😃 Just checking it wasn't lost in PR purgatory 😛 |
|
@matt-l-w I needed the reminder! I was pretty happy when I saw the PR and don't want it to slip through the cracks :) |
kimberlythegeek
left a comment
kimberlythegeek
left a comment
There was a problem hiding this comment.
I really appreciate this work! Thanks again!
|
|
||
| Node dependencies must be installed by running `npm install` inside the axe-selenium-python directory. | ||
|
|
||
| You can run the tests using |
There was a problem hiding this comment.
Thanks for this! Sometimes I struggle with writing thorough documentation.
| """ | ||
| template = "return axe.run(%s).then(function(result){return result;});" | ||
| template = "var callback = arguments[arguments.length - 1];" \ | ||
| "axe.run(%s).then(results => callback(results))" |
There was a problem hiding this comment.
Awesome work :)
I don't have a lot of experience with JavaScript; I tried a lot of different approaches and didn't get it to work!
2 participants
Fixes #118 - empty results on chrome driver.
The issue was not using the correct method on the JavascriptExecutor interface. We can run the script asyncronously and return the results using the callback.
I've also added a test case to use a chromedriver.