Add LDAP Tracing Panel to the third-party list #1433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDAP Operations Tracing panel from django-windowsauth module. GitHub: https://github.com/danyi1212/django-windowsauth Docs: https://django-windowsauth.readthedocs.io/en/latest/howto/debug_toolbar.html
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 29 29
Lines 1577 1577
Branches 220 220
=======================================
Hits 1379 1379
Misses 146 146
Partials 52 52 Continue to review full report at Codecov.
|
tim-schilling
requested changes
Jan 11, 2021
Member
tim-schilling
left a comment
tim-schilling
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have a few nitpicks before merging.
Fixed alphabetic order, typo, and line too long.
Lint warning
tim-schilling
approved these changes
Jan 14, 2021
Member
tim-schilling
left a comment
tim-schilling
left a comment
There was a problem hiding this comment.
Thank you for making those changes and for the PR! I'll merge this shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDAP Operations Tracing panel from django-windowsauth module.
GitHub: https://github.com/danyi1212/django-windowsauth
Docs: https://django-windowsauth.readthedocs.io/en/latest/howto/debug_toolbar.html