Skip to content

Conversation

@albertyw
Copy link
Contributor

@albertyw albertyw commented Dec 4, 2019

This is a subset of #965 that keeps backwards compatibility by only adding support for django 3.0 and python 3.8, instead of removing support for older versions of django and python.

Add support for python 3.8 - Released October 2019
Add support for django 3.0 - Released December 2019

Prerequisite for #964

@albertyw
Copy link
Contributor Author

albertyw commented Dec 4, 2019

So, django-sekizai depends on django-classy-tags, which doesn't have a release which is django 3.0 compatible. There's a PR on the latter to support django 3.0 (django-cms/django-classy-tags#46), but hasn't had movement in over 2 months.

Not sure how we want to proceed. We could have django-compressor pin a fork of django-classy-tags but that seems unsafe. We could also drop django-sekizai, but that would be backwards incompatible

@albertyw albertyw mentioned this pull request Dec 4, 2019
@karyon
Copy link
Contributor

karyon commented Dec 5, 2019

Thanks! with regards to django-classy-tags, i left them a review and a comment. Lets see whether there's a response within, say, a week or so. If they don't move, I'd tend towards using a fork, while it's not elegant I think it's still fine since we're using it strictly for testing only.

@albertyw albertyw force-pushed the add-support branch 2 times, most recently from 566608d to e037877 Compare December 14, 2019 19:26
@albertyw
Copy link
Contributor Author

albertyw commented Dec 14, 2019

I fixed a deprecation and rebased. This should be ready to merge now.

(codecov is saying that there's an issue with one of the python files decreasing coverage but that's only because it's not reading the coverage from the django 3.0 test)

@diox diox merged commit 33ca8eb into django-compressor:develop Dec 19, 2019
@albertyw albertyw deleted the add-support branch December 20, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants