Skip to content

Add missing test for atomic update set method #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Add missing test for atomic update set method #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ def test_add_with_boost(self):
self.assertEqual(len(res), 5)
self.assertEqual('doc_6', res.docs[0]['id'])

def test_field_update(self):
def test_field_update_inc(self):
originalDocs = self.solr.search('doc')
self.assertEqual(len(originalDocs), 3)
updateList = []
Expand All @@ -601,6 +601,25 @@ def test_field_update(self):
self.assertEqual(True, all(updatedDoc[k] == originalDoc[k] for k in updatedDoc.keys()
if k not in ['_version_', 'popularity']))

def test_field_update_set(self):
originalDocs = self.solr.search('doc')
updated_popularity = 10
self.assertEqual(len(originalDocs), 3)
updateList = []
for i, doc in enumerate(originalDocs):
updateList.append({'id': doc['id'], 'popularity': updated_popularity})
self.solr.add(updateList, fieldUpdates={'popularity': 'set'})

updatedDocs = self.solr.search('doc')
self.assertEqual(len(updatedDocs), 3)
for i, (originalDoc, updatedDoc) in enumerate(zip(originalDocs, updatedDocs)):
self.assertEqual(len(updatedDoc.keys()), len(originalDoc.keys()))
self.assertEqual(updatedDoc['popularity'], updated_popularity)
# TODO: change this to use assertSetEqual:
self.assertEqual(True, all(updatedDoc[k] == originalDoc[k] for k in updatedDoc.keys()
if k not in ['_version_', 'popularity']))

def test_field_update_add(self):
self.solr.add([
{
'id': 'multivalued_1',
Expand Down