Improve warning for ExportViewFormMixin #1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
force-pushed
the
improve_mixin_warning
branch
from
ebb3e5c to
808877b
Compare
adamchainz
force-pushed
the
improve_mixin_warning
branch
from
808877b to
a9ca23f
Compare
matthewhegarty
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The existing warning added in #1667 did not reveal which class used the deprecated mixin.
Solution
Transform this warning to run at class definition time using
object.__init_subclass__. Then the deprecated line is shown as the point of class definition.Acceptance Criteria
Tested in my own project. Modified the tests here, though none check the warning message.