WIP RelationshipView

Author: Leifur Halldor Asgeirsson

example/tests/test_views.py

@@ -1,6 +1,7 @@
 from django.utils import timezone
 from rest_framework.reverse import reverse
-from rest_framework.test import APITestCase
+from rest_framework.test import APITestCase, APIRequestFactory
+import json
 
 from rest_framework_json_api.utils import format_relation_name
 
@@ -11,6 +12,7 @@
 class TestRelationshipView(APITestCase):
     def setUp(self):
         self.blog = Blog.objects.create(name='Some Blog', tagline="It's a blog")
+        self.other_blog = Blog.objects.create(name='Other blog', tagline="It's another blog")
         self.entry = Entry.objects.create(
             blog=self.blog,
             headline='headline',
@@ -36,3 +38,19 @@ def test_get_entry_relationship_invalid_field(self):
 
     def test_get_blog_relationship_entry_set(self):
         response = self.client.get('/blogs/{}/relationships/entry_set'.format(self.blog.id))
+
+    def test_put_entry_relationship_blog_returns_405(self):
+        url = '/entries/{}/relationships/blog'.format(self.entry.id)
+        response = self.client.put(url, data={})
+        assert response.status_code == 405
+
+    def test_patch_to_one_relationship(self):
+        url = '/entries/{}/relationships/blog'.format(self.entry.id)
+        request_data = {
+            'data': {'type': format_relation_name('Blog'), 'id': str(self.other_blog.id)}
+        }
+        response = self.client.patch(url, data=json.dumps(request_data), content_type='application/vnd.api+json')
+        assert response.status_code == 200, response.content.decode()
+
+        response = self.client.get(url)
+        assert response.data == request_data['data']

rest_framework_json_api/parsers.py

@@ -34,6 +34,9 @@ def parse(self, stream, media_type=None, parser_context=None):
         data = result.get('data', {})
 
         if data:
+            from rest_framework_json_api.views import RelationshipView
+            if isinstance(parser_context['view'], RelationshipView):
+                return data  # temporary workaround
             # Check for inconsistencies
             resource_name = utils.get_resource_name(parser_context)
             if data.get('type') != resource_name:

rest_framework_json_api/views.py

@@ -4,6 +4,7 @@
 from rest_framework.response import Response
 from rest_framework.renderers import JSONRenderer
 from rest_framework_json_api.serializers import ResourceIdentifierObjectSerializer
+from rest_framework_json_api.utils import format_relation_name, get_resource_type_from_instance
 from rest_framework.exceptions import NotFound
 
 
@@ -12,36 +13,48 @@ class RelationshipView(generics.GenericAPIView):
     renderer_classes = (JSONRenderer, )
 
     def get(self, request, *args, **kwargs):
-        related_instance = self.get_related_instance(kwargs)
-        serializer_instance = self.instantiate_serializer(related_instance)
+        related_instance = self.get_related_instance()
+        serializer_instance = self._instantiate_serializer(related_instance)
         return Response(serializer_instance.data)
 
-    def put(self, request, *args, **kwargs):
-        return Response()
-
     def patch(self, request, *args, **kwargs):
-        return Response()
+        parent_obj = self.get_object()
+        if hasattr(parent_obj, kwargs['related_field']):
+            related_model_class = self.get_related_instance().__class__
+            serializer = self.get_serializer(data=request.data, model_class=related_model_class)
+            serializer.is_valid(raise_exception=True)
+            setattr(parent_obj, kwargs['related_field'], serializer.validated_data)
+            parent_obj.save()
+            return Response(serializer.data)
 
     def post(self, request, *args, **kwargs):
         return Response()
 
     def delete(self, request, *args, **kwargs):
         return Response()
 
-    def get_related_instance(self, kwargs):
+    def get_related_instance(self):
         try:
-            return getattr(self.get_object(), kwargs['related_field'])
+            return getattr(self.get_object(), self.kwargs['related_field'])
         except AttributeError:
             raise NotFound
 
-    def instantiate_serializer(self, instance):
-        serializer_class = self.get_serializer_class()
+    def _instantiate_serializer(self, instance):
         if isinstance(instance, Model):
-            return serializer_class(instance=instance)
+            return self.get_serializer(instance=instance)
         else:
             if isinstance(instance, (QuerySet, BaseManager)):
                 instance = instance.all()
 
-            return serializer_class(instance=instance, many=True)
+            return self.get_serializer(instance=instance, many=True)
+
+    def get_resource_name(self):
+        if not hasattr(self, '_resource_name'):
+            instance = getattr(self.get_object(), self.kwargs['related_field'])
+            self._resource_name = format_relation_name(get_resource_type_from_instance(instance))
+        return self._resource_name
 
+    def set_resource_name(self, value):
+        self._resource_name = value
 
+    resource_name = property(get_resource_name, set_resource_name)