Fixed #10827 -- Ensured ContentTypes are created before permission creation #10001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charettes
reviewed
May 28, 2018
There was a problem hiding this comment.
Does it break anything if this is moved to the top? I would assume this module can safely depend on the latter?
charettes
approved these changes
May 28, 2018
tests/auth_tests/test_management.py
Outdated
There was a problem hiding this comment.
I'd be great to assert the permission and content types were appropriately created as well!
There was a problem hiding this comment.
Yes, I was bitten by this today, and thought it is enough time lost by fellow developers!
charettes
reviewed
May 28, 2018
There was a problem hiding this comment.
On thing to keep in mind is that this is going to be introducing double work.
|
Sure, this reminds us about the wider discussion of INSTALLED_APPS ordering. I agree on discussing this elsewhere, because this bug has waited for too long now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/10827