Add asgi support to runserver #12969
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 24, 2020 13:12
We use sync_to_async because there is no native async file support
Daphne is used as the asgi server. It is optional. The command will error if daphne is not installed
massover
force-pushed
the
add-asgi-runserver
branch
from
108c401 to
9be7fce
Compare
|
As per the ticket, I think we need to pin this down a bit more before we proceed. (Let's follow up on the forum thread.) I'm a little worried about coding in the dependency on Daphne, even if supposedly optional. (Install Closing for now. We can reopen if we decide to proceed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code adds support to run an asgi daphne based development server while leaving the default wsgi.
./manage.py runserver --asgihttps://code.djangoproject.com/ticket/31626