Skip to content

Fixed #32309 -- Added --exclude option to startapp/startproject management commands. #13827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2021
Merged

Fixed #32309 -- Added --exclude option to startapp/startproject management commands. #13827

merged 2 commits into from
Sep 1, 2021

Conversation

laymonage
Copy link
Contributor

@laymonage laymonage changed the title WIP: Fixed #32309 -- Added --directory option to template management command. Fixed #32309 -- Added --exclude option to template management command. Jan 13, 2021
Base automatically changed from master to main March 9, 2021 06:21
@felixxm
Copy link
Member

felixxm commented Jul 9, 2021

@laymonage Do you have time to keep working on this?

@laymonage
Copy link
Contributor Author

Hey @felixxm,
Sure, but I'd like to know whether the proposed solution is acceptable or if there's a better alternative.

@felixxm
Copy link
Member

felixxm commented Jul 9, 2021

@carltongibson's and @rfleschenberg's reactions were positive, so IMO you have the green light 🚥

@laymonage
Copy link
Contributor Author

@felixxm Okay, I'll try adding tests and docs this weekend.

@laymonage laymonage marked this pull request as ready for review July 18, 2021 03:20
cjerdonek
cjerdonek reviewed Jul 18, 2021
View reviewed changes
cjerdonek
cjerdonek reviewed Jul 18, 2021
View reviewed changes
@laymonage laymonage force-pushed the ticket_32309 branch 2 times, most recently from 09064d3 to 1980e6c Compare July 24, 2021 01:06
jacobtylerwalls
jacobtylerwalls reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Just a cosmetic suggestion.

cjerdonek
cjerdonek reviewed Aug 22, 2021
View reviewed changes
@felixxm felixxm changed the title Fixed #32309 -- Added --exclude option to template management command. Fixed #32309 -- Added --exclude option to startapp/startproject management commands. Sep 1, 2021
@felixxm
Copy link
Member

felixxm commented Sep 1, 2021

@laymonage Thanks for this patch 👍

I pushed small edits and moved extra test coverage to a separate commit.

@felixxm felixxm merged commit 84c7c4a into django:main Sep 1, 2021
@laymonage
Copy link
Contributor Author

Thanks! 🎉

@lucasrcezimbra lucasrcezimbra mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls left review comments

+1 more reviewer

@cjerdonek cjerdonek cjerdonek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@laymonage @felixxm @cjerdonek @jacobtylerwalls