Skip to content

Changed signatures of setting_changed signal receivers. #15185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Changed signatures of setting_changed signal receivers. #15185

merged 1 commit into from
Dec 17, 2021

Conversation

adamchainz
Copy link
Member

No description provided.

ngnpope
ngnpope approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@ngnpope ngnpope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is something that only became possible with being able to specify keyword-only arguments since Python 3.0.

(Test failure is unrelated and flaky.)

@adamchainz
Copy link
Member Author

(Test failure is unrelated and flaky.)

Is this being investigated?

@adamchainz adamchainz mentioned this pull request Dec 13, 2021
Closed
@felixxm
Copy link
Member

felixxm commented Dec 13, 2021

(Test failure is unrelated and flaky.)

Is this being investigated?

Yes, see ticket-32831.

@felixxm felixxm changed the title Simplified signatures of setting_changed receivers. Changed signatures of setting_changed signal receivers. Dec 17, 2021
@felixxm
Copy link
Member

felixxm commented Dec 17, 2021

@adamchainz Thanks 👍

@felixxm felixxm merged commit b0d16d0 into django:main Dec 17, 2021
@adamchainz adamchainz deleted the setting_changed branch December 17, 2021 16:13
adamchainz added a commit to adamchainz/django-debug-toolbar that referenced this pull request Dec 20, 2021
@adamchainz
Move settings reset logic to settings module.
8fe2222 
This makes it apply in every project using django-debug-toolbar, so packages or projects can reconfigure the toolbar during tests if required.

The receiver functions have also been combined and optimized the signature like django/django#15185 .
@adamchainz adamchainz mentioned this pull request Dec 20, 2021
Merged
adamchainz added a commit to adamchainz/django-debug-toolbar that referenced this pull request Dec 20, 2021
@adamchainz
Move settings reset logic to settings module.
65cea8d 
This makes it apply in every project using django-debug-toolbar, so packages or projects can reconfigure the toolbar during tests if required.

The receiver functions have also been combined and optimized the signature like django/django#15185 .
matthiask pushed a commit to django-commons/django-debug-toolbar that referenced this pull request Dec 20, 2021
@adamchainz
Move settings reset logic to settings module. (#1559)
afc5dfc 
This makes it apply in every project using django-debug-toolbar, so packages or projects can reconfigure the toolbar during tests if required.

The receiver functions have also been combined and optimized the signature like django/django#15185 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ngnpope ngnpope ngnpope approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamchainz @felixxm @ngnpope