Skip to content

Conversation

@willymwaura
Copy link

No description provided.

@github-actions
Copy link

Hello @willymwaura! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willymwaura Thanks for this patch 👍, however I think the current docs are sufficient in these areas.


If you set :setting:`DEBUG` to ``False``, you also need to properly set
the :setting:`ALLOWED_HOSTS` setting.
INSTALLED_APPS is used to register our apps in a project and register modules we are using in our project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is a topic about settings not a reference. I don't think we need any more settings in this short example.

Comment on lines +78 to +79
App
A small library representing a discrete part of a larger project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This term is not referenced anywhere in the docs. Moreover the differences between apps and projects are described several times in the docs, e.g.

@felixxm felixxm closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants