Skip to content

Fixes #32602 -- Clarify wording re: parallel testing and test case vs. test case class #17162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fixes #32602 -- Clarify wording re: parallel testing and test case vs. test case class #17162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4753ab8
Renamed partition_suite_by_case to partition_suite_by_test_class, upd…
MandadiMahendharReddy Aug 11, 2023
8c224dc
Updated text in advaced.txt and django-admin.txt
MandadiMahendharReddy Aug 12, 2023
e9dde36
Reverted django/test/runner.py as per code review comment
MandadiMahendharReddy Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ answer newbie questions, and generally made Django that much better:
Makoto Tsuyuki <mtsuyuki@gmail.com>
Malcolm Tredinnick
Manav Agarwal <dpsman13016@gmail.com>
Mandadi Manehdnar Reddy <mandadimahendharreddy8523@gmail.com>
Manuel Saelices <msaelices@yaco.es>
Manuzhai
Marc Aymerich Gubern
Expand Down
3 changes: 1 addition & 2 deletions docs/ref/django-admin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,8 +1484,7 @@ override this by passing the desired number of processes, e.g.
variable.

Django distributes test cases — :class:`unittest.TestCase` subclasses — to
subprocesses. If there are fewer test cases than configured processes, Django
will reduce the number of processes accordingly.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you removed: "Django will reduce the number of processes accordingly"? This ticket is about clarifying wording test/test case/test case class, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @felixxm,as per this
image I replaced that line with "If there are fewer test case classes than configured processes."

Copy link
Member

@felixxm felixxm Aug 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this ticket is about clarifying wording test/test case/test case class, etc. The sentence that you removed is correct and should be kept.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is only an example from the ticket description, you should audit all docs and check used wording ( test/test case/test case class).

subprocesses. If there are fewer test case classes than configured processes.

Each process gets its own database. You must ensure that different test cases
don't access the same resources. For instance, test cases that touch the
Expand Down
8 changes: 4 additions & 4 deletions docs/topics/testing/advanced.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,10 +569,10 @@ and tear down the test suite.
set to prior to running tests.

``parallel`` specifies the number of processes. If ``parallel`` is greater
than ``1``, the test suite will run in ``parallel`` processes. If there are
fewer test cases than configured processes, Django will reduce the number
of processes accordingly. Each process gets its own database. This option
requires the third-party ``tblib`` package to display tracebacks correctly.
than ``1``, the test suite will run in ``parallel`` processes. If there are
fewer test case classes than configured processes. Each process gets its own
database. This option requires the third-party ``tblib`` package to display
tracebacks correctly.

``tags`` can be used to specify a set of :ref:`tags for filtering tests
<topics-tagging-tests>`. May be combined with ``exclude_tags``.
Expand Down