Skip to content

Fixed invalid html templates in tests. #19029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025
+5 −4
Merged

Fixed invalid html templates in tests. #19029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/forms_tests/templates/forms_tests/custom_field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{{ field.label_tag }}
<p>Custom Field<p>
<p>Custom Field</p>
{{ field }}
6 changes: 3 additions & 3 deletions tests/forms_tests/tests/test_forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5354,7 +5354,7 @@ class MyForm(Form):
f = MyForm()
self.assertHTMLEqual(
f.render(),
'<div><label for="id_first_name">First name:</label><p>Custom Field<p>'
'<div><label for="id_first_name">First name:</label><p>Custom Field</p>'
'<input type="text" name="first_name" required id="id_first_name"></div>',
)

Expand All @@ -5365,7 +5365,7 @@ class MyForm(Form):
f = MyForm()
self.assertHTMLEqual(
f["first_name"].render(template_name="forms_tests/custom_field.html"),
'<label for="id_first_name">First name:</label><p>Custom Field<p>'
'<label for="id_first_name">First name:</label><p>Custom Field</p>'
'<input type="text" name="first_name" required id="id_first_name">',
)

Expand Down Expand Up @@ -5393,7 +5393,7 @@ class Person(Form):
html = t.render(Context({"form": Person()}))
expected = """
<label for="id_first_name">First name:</label>
<p>Custom Field<p>
<p>Custom Field</p>
<input type="text" name="first_name" required id="id_first_name">
"""
self.assertHTMLEqual(html, expected)
Expand Down
1 change: 1 addition & 0 deletions tests/view_tests/templates/jsi18n-multi-catalogs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<head>
<script src="/jsi18n/app1/"></script>
<script src="/jsi18n/app2/"></script>
</head>
<body>
<p id="app1string">
<script>
Expand Down
Loading