Refs #35303 -- Made small optimizations in alogout() and aget_user(). #19756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In alogout(), there is no need to check the is_authenticated attribute when user is None. In aget_user(), there is no need to call get_session_auth_hash() twice. Follow up to 50f89ae.
felixxm
commented
Aug 20, 2025
| session_auth_hash = user.get_session_auth_hash() | ||
| session_hash_verified = session_hash and constant_time_compare( | ||
| session_hash, user.get_session_auth_hash() | ||
| session_hash_verified = constant_time_compare( |
There was a problem hiding this comment.
session_hash is always truthy here.
|
@sarahboyce Thanks for checking 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
alogout(), there is no need to check theis_authenticatedattribute whenuser is None.In
aget_user(), there is no need to callget_session_auth_hash()twice.Follow up to 50f89ae.