Fixed #36508 -- Interpreted __iexact=None on KeyTransforms as __exact=None. #19793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildbot, test on oracle. |
…=None. Thanks Jacob Walls for the report.
sarahboyce
force-pushed
the
ticket-36508
branch
from
4886931 to
48ce520
Compare
sarahboyce
approved these changes
Sep 25, 2025
sarahboyce
reviewed
Sep 25, 2025
Comment on lines
+1434
to
+1442
| # Interpret '__exact=None' as the SQL 'IS NULL'. For '__iexact=None' on | ||
| # KeyTransform, interpret it as '__exact=None' instead of 'IS NULL' | ||
| # (#36508). For all other cases, reject the use of None as a query | ||
| # value unless the lookup explicitly supports it. | ||
| if lookup.rhs is None and not lookup.can_use_none_as_rhs: | ||
| if lookup_name not in ("exact", "iexact"): | ||
| raise ValueError("Cannot use None as a query value") | ||
| if lookup_name == "iexact" and isinstance(lhs, KeyTransform): | ||
| return lhs.get_lookup("exact")(lhs, None) |
There was a problem hiding this comment.
Having had another think, it would be preferable if we don't add json specific logic here
Can we not update django.db.models.fields.json.KeyTransformIExact somehow?
There was a problem hiding this comment.
I share your sentiment @sarahboyce, this should be implemented at the KeyTransformIExact level and not hardcoded here. The reason why exact and iexact are here today is due to how they must span OUTER JOIN when targeting a reverse relationship, I hope to remove it entirely with #16817.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36508
Branch description
Matches expectations by reserving the use of
Nonein key transform lookups for JSON null.Checklist
mainbranch.