Fixed #36648, Refs #33772 -- Accounted for composite pks in first()/last() when aggregating. #19955
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thank you for your contribution 💪 As it's your first contribution be sure to check out the patch review checklist. If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket! If you have any design or process questions then you can ask in the Django forum. Welcome aboard ⛵️! |
nessita
approved these changes
Oct 14, 2025
jacobtylerwalls
force-pushed
the
jtw/first-pk-exception
branch
from
a9a6eef to
06028eb
Compare
…ast() when aggregating.
jacobtylerwalls
force-pushed
the
jtw/first-pk-exception
branch
from
06028eb to
a8b7341
Compare
jacobtylerwalls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36648
Branch description
Before,
.first()and.last()checked if the primary key was already in the group by for an aggregation, otherwise it threw aTypeError. (See ticket-33772).Now, if you have a composite primary key, you can also provide each column individually in a
values()call instead of needing to use the"pk"syntax.Checklist
mainbranch.