Skip to content

Refs #36596 -- Skipped SchemaIndexesNotPostgreSQLTests on Postgres. #20007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nessita wants to merge 1 commit into from
+2 −5
Closed

Refs #36596 -- Skipped SchemaIndexesNotPostgreSQLTests on Postgres. #20007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions django/db/backends/postgresql/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
@cached_property
def django_test_skips(self):
skips = {
"opclasses are PostgreSQL only.": {
"indexes.tests.SchemaIndexesNotPostgreSQLTests."
"test_create_index_ignores_opclasses",
},
"PostgreSQL requires casting to text.": {
"lookup.tests.LookupTests.test_textfield_exact_null",
},
Expand Down
3 changes: 2 additions & 1 deletion tests/indexes/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import datetime
from unittest import skipUnless
from unittest import skipIf, skipUnless

from django.conf import settings
from django.db import connection
Expand Down Expand Up @@ -106,6 +106,7 @@ def test_alter_field_unique_false_removes_deferred_sql(self):
self.assertIn("charfield_added", str(editor.deferred_sql[0].parts["name"]))


@skipIf(connection.vendor == "postgresql", "No PostgreSQL tests")
Copy link
Member

@felixxm felixxm Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, this test was already skipped by django_test_skips. What does it change to use skipIf instead?

Copy link
Member

@felixxm felixxm Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like an issue with django_test_skips and forkserver 🤔

Copy link
Member

@felixxm felixxm Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like an issue with django_test_skips and forkserver 🤔

It's a general issue with parallel tests execution with spawn and forkserver, see alternative PR #20012.

Copy link
Contributor Author

@nessita nessita Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Mariusz. As you found out, yes this is an issue with django_test_skips and the parallel tests, reported by Jacob in the referenced ticket-36596 (and django_test_expected_failures are also affected). I'll continue the conversation in your PR.

class SchemaIndexesNotPostgreSQLTests(TransactionTestCase):
available_apps = ["indexes"]

Expand Down