Fixed #28222 - Allow non-field model property attributes in defaults passed update_or_create()/get_or_create()

[amykyta]

Allow the defaults argument to update_or_create()/get_or_create() to contain property attributes. The added tests further demonstrate the issue.

For context, in 1.11 the defaults argument passed to update_or_create() and get_or_create() is validated and non-fields are reported as FieldErrors (introduced by #7255). There is an exception made for pk (added in #7338) but I believe it should apply to all _meta._property_names for the creation behavior to be consistent with Model.create and better backwards compatibility.

One thing to note @francoisfreitag, if self.model._meta._property_names always has pk then the param test can be made simpler by not checking for pk explicitly.

https://code.djangoproject.com/ticket/28222

[francoisfreitag]

I think the comment from _property_names should change.

[amykyta]

What should it change to?

[amykyta]

I've updated the comment to mention the new use.

[francoisfreitag]

When I remove the setter from the code, I get the following TypeError:

======================================================================
ERROR: test_get_or_create_with_model_property_defaults (get_or_create.tests.GetOrCreateTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.6/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib64/python3.6/unittest/case.py", line 601, in run
    testMethod()
  File "/home/freitafr/dev/django/tests/get_or_create/tests.py", line 80, in test_get_or_create_with_model_property_defaults
    t, _ = Thing.objects.get_or_create(defaults={'capitalized_name_property': "annie"}, pk=1)
  File "/home/freitafr/dev/django/django/db/models/manager.py", line 82, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/home/freitafr/dev/django/django/db/models/query.py", line 452, in get_or_create
    return self._create_object_from_params(lookup, params)
  File "/home/freitafr/dev/django/django/db/models/query.py", line 484, in _create_object_from_params
    obj = self.create(**params)
  File "/home/freitafr/dev/django/django/db/models/query.py", line 378, in create
    obj = self.model(**kwargs)
  File "/home/freitafr/dev/django/django/db/models/base.py", line 484, in __init__
    raise TypeError("'%s' is an invalid keyword argument for this function" % list(kwargs)[0])
TypeError: 'capitalized_name_property' is an invalid keyword argument for this function

I think Django should verify that the field can be set, just like the model initialization does (see ticket #25910).

[amykyta]

Good point but the model init code is actually setting the values, not just checking it there.

[amykyta]

@francoisfreitag , I've looked into this and do not understand your suggestion. That TypeError is the result of the work in ticket #25910. Can you please clarify what you meant?

[timgraham]

I think the suggestion is to maintain the "Invalid field name(s) for model ..." error message a property that doesn't have a setter.

[amykyta]

That helps. Thanks, Tim.