Skip to content

Updated search box shortcut and made it visible #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 23, 2022
Merged

Updated search box shortcut and made it visible #1236

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f81e7b
Updated search box shortcut and made it visible.
megaden Oct 12, 2022
79c4638
Rearranged checks to do cheaper ones first.
megaden Oct 12, 2022
f61b8f7
Adding platform-specific shortcut to input placeholder client side.
megaden Oct 12, 2022
144731a
Fixed whitespace.
megaden Oct 12, 2022
633dfd0
A few minor tweaks.
megaden Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions djangoproject/static/js/mod/search-key.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
define([
'jquery' //requires jquery
], function( $ ) {

var SearchForm = function(search_form) {
const SearchForm = function(search_form) {
this.search_form = $(search_form); // the search form
this.init();
};

SearchForm.prototype = {
init: function(){
var self = this;
const self = this;
$(document).ready(function () {
$(window).keypress(function(e) {
if ($('input:focus, textarea:focus').length === 0 &&
e.which === 47) { // The slash is 47.
self.search_form.find('input').focus().select();
const search_form_input = self.search_form.find('input');
const raw_placeholder = search_form_input.attr('placeholder');
const shortcut = navigator.userAgent.indexOf("Mac") === -1 ? "⌘ + K" : "Ctrl + K";
search_form_input.attr('placeholder', `${raw_placeholder} (${shortcut})`);

$(window).keydown(function(e) {
if ((e.metaKey || e.ctrlKey) && e.key === 'k' && $('input:focus, textarea:focus').length === 0) {
search_form_input.focus().select();
search_form_input[0].scrollIntoView({ behavior: "smooth", block: "start" });
return false;
}
});
Expand Down