Skip to content

Fix unsound Send impls. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Fix unsound Send impls. #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 2 additions & 34 deletions src/linked_hash_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,22 +973,6 @@ where
}
}

unsafe impl<K, V, S> Send for RawEntryBuilder<'_, K, V, S>
where
K: Send,
V: Send,
S: Send,
{
}

unsafe impl<K, V, S> Sync for RawEntryBuilder<'_, K, V, S>
where
K: Sync,
V: Sync,
S: Sync,
{
}

pub struct RawEntryBuilderMut<'a, K, V, S> {
map: &'a mut LinkedHashMap<K, V, S>,
}
Expand Down Expand Up @@ -1044,22 +1028,6 @@ where
}
}

unsafe impl<K, V, S> Send for RawEntryBuilderMut<'_, K, V, S>
where
K: Send,
V: Send,
S: Send,
{
}

unsafe impl<K, V, S> Sync for RawEntryBuilderMut<'_, K, V, S>
where
K: Sync,
V: Sync,
S: Sync,
{
}

pub enum RawEntryMut<'a, K, V, S> {
Occupied(RawOccupiedEntryMut<'a, K, V, S>),
Vacant(RawVacantEntryMut<'a, K, V, S>),
Expand Down Expand Up @@ -1447,8 +1415,8 @@ impl<K, V> Drain<'_, K, V> {

unsafe impl<K, V> Send for Iter<'_, K, V>
where
K: Send,
V: Send,
K: Sync,
V: Sync,
{
}

Expand Down