Make namespace paths consistently refer to full namespace #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeap this works! |
Contributor
|
I think the deserialization still fails with a UnknownPrefix error. Extending the test to include a FromXml test should reveal this I belief. |
Owner
Author
Nice catch! Fixed it. |
Owner
Author
|
(Please file new issues if you run into more stuff, instead of commenting on the old issue. 👍) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FromXmlandToXmltreatedns(foo)on fields inconsistently:FromXmltreatedfooas a path to a constant containing the full namespace stringToXmltreatedfooas a namespace prefix defined on the container typeChange the
ToXmltreatment to match theFromXmltreatment, favoring less indirection.Use a semver-incompatible version bump to signal the potential incompatibility.
cc @vshashi01