Skip to content

Conversation

@djc
Copy link
Member

@djc djc commented Dec 22, 2019

No description provided.

@github-actions
Copy link

Pull Request Test Coverage Report for Build a4f1203a514f092e5df9260a2283c7abca937a1c-PR-576

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 70.638%

Totals Coverage Status
Change from base Build ffb224e2161c45ea0ac83cf5abed0391a132517a: -0.002%
Covered Lines: 9967
Relevant Lines: 14110

💛 - Coveralls

@djc djc force-pushed the fix-lints branch 3 times, most recently from c1c79df to af88f26 Compare December 22, 2019 22:03
@djc
Copy link
Member Author

djc commented Dec 22, 2019

Okay, that was a slog. Maybe someone can look into that AtomicBool thing in interop, but I ran out of steam after this, and I'm neither familiar with that code nor with AtomicBool.

@djc
Copy link
Member Author

djc commented Dec 22, 2019

(Also fixing these being a slog is a pretty good reason to maintain them through CI. I just hope there's not too much churn.)

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@Ralith Ralith merged commit f4b8cbe into master Dec 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-lints branch December 22, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants