fix cancel the job return the false status #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djm
added a commit
that referenced
this pull request
Mar 27, 2016
NB: Breaking change Prior to this commit, the method simply returned True if the "prevstate" (previous state) of the cancelled spider was reported as "running" by scrapyd. While correct, the spider could also have been in the "pending" state when cancelled and in this instance our wrapper would have reported False. This also went counter to what the docs suggested. The major version number will be bumped as a result of this change. Thanks to @BruceDone for raising and fixing the issue as part of #6.
Owner
|
Thanks for bringing this to my attention @BruceDone! I decided that the As it is a breaking change, I've bumped the version to 2.x and just released it to PyPi. Also I added you up to the Authors file, many thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi djm:
since you cancel the pending job successfully ,the response json prevstate should be pending ,and the result should be true .