Skip to content

Task/20190121/post message#24

Merged
nicewook merged 3 commits intomasterfrom
task/20190121/post-message
Jan 22, 2019
Merged

Task/20190121/post message#24
nicewook merged 3 commits intomasterfrom
task/20190121/post-message

Conversation

@kkweon
Copy link
Member

@kkweon kkweon commented Jan 22, 2019

Summary

Closes #18

  • 채널에서 시간 입력시 자동으로 변환합니다
    image

  • 슬래시 커맨드(/time 2019-01-21 19:00 PST) 는 이제 반응할때 더이상 전체 공개 메시지로 작성하지 않습니다

@kkweon kkweon force-pushed the task/20190121/post-message branch from 965fef7 to 4671515 Compare January 22, 2019 03:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 121

  • 15 of 91 (16.48%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-22.3%) to 58.647%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/slack/post_message.go 0 34 0.0%
api/slack/event.go 8 50 16.0%
Totals Coverage Status
Change from base Build 114: -22.3%
Covered Lines: 156
Relevant Lines: 266

💛 - Coveralls

@kkweon
Copy link
Member Author

kkweon commented Jan 22, 2019

😭 커버리지가 22%나 떨어지는군요

Copy link
Member

@nicewook nicewook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드들이 이쁩니다.
:)

@nicewook nicewook merged commit e8f4bfa into master Jan 22, 2019
@nicewook nicewook deleted the task/20190121/post-message branch January 22, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants