Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jun 6, 2017

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 6, 2017

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Fix Bugzilla Description
6227 Comparison of different enums

@UplinkCoder
Copy link
Member

looks good.

@wilzbach
Copy link
Contributor Author

The deprecation is already part of DMD, so anything blocking this?

@wilzbach
Copy link
Contributor Author

CC @CyberShadow - can we get this shipped before the 2.075 release which includes this deprecation? :)

deprecate.dd Outdated
)

$(H3 $(DEPNAME Implicit comparison of different enums))
$(P Currently, comparison of different enumerated type is allowed:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Currently" is not going to be current for much longer

@wilzbach
Copy link
Contributor Author

"Currently" is not going to be current for much longer

Hehe, I copied this from the entry below -> I changed the tense for both entries.

@wilzbach wilzbach force-pushed the deprecate-enum-comparison branch 2 times, most recently from a4efed6 to 007c450 Compare June 27, 2017 21:58
@dlang-bot dlang-bot merged commit d918429 into dlang:master Jun 27, 2017
@wilzbach wilzbach deleted the deprecate-enum-comparison branch December 18, 2017 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants