Show latest article of the DBlog on the frontpage #1710

wilzbach · 2017-06-15T12:51:12Z

I just had this crazy idea and funnily it works quite well - even with Ddoc :)

This definition is only used when DIFFABLE is not set, so it won't be possible to preview this on the DAutoTest, but here's how it will look in action:

.

For a local build without internet, curl will fail silently and it will just create an empty file.
On subsequent runs, this target won't be executed. (No .PHONY).

This approach is also nicer than the previous JavaScript injection, because search engines see the new content & they like sites that are updated often.

It's fairly unlikely that the DBlog theme will change soon and if - as said before - it will just silently fail ...

CC @mdparker @JackStouffer @CyberShadow

PetarKirov · 2017-06-15T13:31:13Z

index.dd

-            $(P Stay updated with
-                $(LINK2 http://arsdnet.net/this-week-in-d,
-                    <cite>This Week in D</cite>) -
-                $(SPANC twid)


Let's keep This Week in D. It's pretty cool, despite not having the "official" stamp on it. Just move it below the official blog. May be something like:

Stay updated with the official D Blog and This Week in D:

D Blog - Compile-Time Sort in D by Michael Parker from June 5, 2017.

This Week in D - May 28: Blog article on optimization and Andrei Israel trip, Beta D 2.074, tip on mixin w/ anon func.

wilzbach · 2017-06-15T14:49:13Z

Let's keep This Week in D. It's pretty cool, despite not having the "official" stamp on it. Just move it below the official blog. May be something like:

I considered this for a moment, but then dropped it because of space problems:

Any ideas?

adamdruppe · 2017-06-15T15:32:08Z

I didn't get a chance to update twid again since I was out of town again.... I wouldn't mind if you simplified or removed it to save space.

PetarKirov · 2017-06-15T16:13:02Z

If space is an issue we can try with this:

Stay updated with:

The official D Blog: Compile-Time Sort in D from June 5 2017, and

This Week in D: May 28.

Or with an even shorter version:

Stay updated with the official D Blog - Compile-Time Sort in D from June 5 2017 and This Week in D - May 28.

wilzbach · 2017-06-15T16:43:43Z

CC @aG0aep6G - as you rescued the Dlang.org template - what's your opinion on this?

CC @popen2 - at DConf you mentioned that you were planning on redesigning dlang.org - maybe you have already an idea in mind?

aG0aep6G · 2017-06-15T20:14:18Z

CC @aG0aep6G - as you rescued the Dlang.org template - what's your opinion on this?

I really dislike how much the home page currently depends on JavaScript, so this is interesting. It feels weird to generate the "latest" stuff when building the site, but if you do that regularly enough, sure.

Does it work, though? The doc tester shows "from : by . ". Also, https://blog.dlang.org doesn't work. Needs "http://".

Regarding space problems, you could cut the DConf text down. One paragraph instead of two; shorter "thank you" or none at all; "through this YouTube playlist" -> "on YouTube" - stuff like that.

Regarding TWID, it doesn't seem very alive. So I'd go with the blog if only one can get in.

CyberShadow · 2017-06-15T22:00:17Z

I think the DConf bit needs to be moved out of the news section and somewhere else, a banner or a sidebar widget. Then there should be enough room for the blog and TWiD in the News section (no need to listify them either, just two paragraphs).

wilzbach · 2017-06-16T01:26:48Z

Does it work, though? The doc tester shows "from : by . ".

Yes as mentioned before, I explicitly disable this (as dynamic content) on the DAutoTest to avoid random changes (DIFFABLE=1 is set on DAutotTest).
However on the deployment, DIFFABLE isn't set. For example, the pending changelog is built similarly.
If the curl trick looks too weird, I can always plugin a simple DScript instead...

Also, https://blog.dlang.org doesn't work. Needs "http://".

Oh thanks!

I think the DConf bit needs to be moved out of the news section and somewhere else, a banner or a sidebar widget. Then there should be enough room for the blog and TWiD in the News section (no need to listify them either, just two paragraphs).

Okay,

I also parse TWID at "Compile-Time" now, so there's one ugly layout reflow less on the main page.
I removed the "Thank you DConf 2017" notice

Now adding the DConf link to "Learn" yields (and slightly adjusting the News intro):

@CyberShadow the only place I could find to put the playlist link was the "Learn" section. Better ideas?

CyberShadow · 2017-06-17T00:14:57Z

Better ideas?

I was thinking maybe take http://dconf.org/2017/images/dconf_logo_2017.svg, crop it, and put it (with some text) in the sidebar above or under the Tweeter widget, what do you think? Plenty of space there.

wilzbach · 2017-06-18T23:46:34Z

I was thinking maybe take http://dconf.org/2017/images/dconf_logo_2017.svg, crop it, and put it (with some text) in the sidebar above or under the Tweeter widget, what do you think? Plenty of space there.

Nice idea - like this? Maybe a bit more spacing?

CyberShadow · 2017-06-18T23:48:08Z

Yep! Could use a bit of text under the logo (essentially what we have in the news section right now).

wilzbach · 2017-06-18T23:56:42Z

Yep! Could use a bit of text under the logo (essentially what we have in the news section right now).

default

12px

CyberShadow · 2017-06-19T00:00:28Z

sitemap.dd

@@ -0,0 +1,203 @@
+Ddoc


Did you add this accidentally?

Yes, I really need some sleep :P
In any case, we should add this to the gitignore or even better: simply put it into .generated
#1725

CyberShadow · 2017-06-19T00:00:35Z

posix.mak

+# Fetch the latest article from the official D blog
+################################################################################
+
+$G/dblog_latest.ddoc:


DIFFABLE, not DIIFABLE

CyberShadow · 2017-06-19T00:02:05Z

posix.mak

+
+$G/twid_latest.ddoc:
+	@echo "Receiving the latest TWID article. Disable with DIIFABLE=1"
+	curl -s --retry 3 --retry-delay 5 http://arsdnet.net/this-week-in-d/twid-latest.js | grep setTwid | \


Is this going to handle special characters nicely?

CyberShadow · 2017-06-19T00:03:00Z

images/dconf_logo_2017.svg

@@ -0,0 +1,213 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>


Hotlinking it would've been fine, but this is fine too

I prefer copying - just in case the layout of dconf.org changes ... (I would like to avoid dependencies on other websites wherever possible).

wilzbach · 2017-06-19T00:11:40Z

index.dd

+                <cite>Programming in D</cite>) or
+                $(LINK2 http://youtube.com/playlist?list=PL3jwVPmk_PRxo23yyoc0Ip_cP3-rCm7eB, watch)
+                talks from
+                $(LINK2 http://dconf.org/2017/index.html, DConf17)


Should I still keep this if we add the DConf banner?

Yeah, not sure how good the talks are effective for actually learning D.

wilzbach · 2017-06-19T00:18:36Z

Is this going to handle special characters nicely?

Example with Regex101

CyberShadow · 2017-06-19T00:19:36Z

If I understand that regex correctly, if a TWiD issue has a " in it, it's not going to show up at all.

CyberShadow · 2017-06-19T00:22:52Z

I don't understand how RFC 3966 plays in this. The TWiD data is a JavaScript file, it's not URL-encoded.

wilzbach · 2017-06-19T00:28:32Z

If I understand that regex correctly, if a TWiD issue has a " in it, it's not going to show up at all.
don't understand how RFC 3966 plays in this. The TWiD data is a JavaScript file, it's not URL-encoded.

Yes & Yes, sorry.
Updated the RegEx: https://regex101.com/r/cGz0vE/2 (at least for TWID I hope that this is only a temporary solution anyways as for @adamdruppe it's probably the same effort to write his latest article information in this extracted Ddoc format than JS).

TWID now stays part of the main page.

dlang-bot · 2017-06-27T05:05:31Z

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

smaller, focused PRs are easier to review than big ones
try not to mix up refactoring or style changes with bug fixes or feature enhancements
provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

wilzbach · 2017-06-27T05:08:02Z

Alrighty, I have fixed all open "issues" and this should be good to go. Anything else blocking this?
(I also squashed the DConf banner changes into one commit).

CyberShadow · 2017-06-27T07:20:31Z

@adamdruppe Any news on twid_latest.dd?

CyberShadow · 2017-06-27T07:21:17Z

posix.mak

+
+$G/twid_latest.ddoc:
+	@echo "Receiving the latest TWID article. Disable with DIFFABLE=1"
+	curl -s --retry 3 --retry-delay 5 http://arsdnet.net/this-week-in-d/twid-latest.js | grep setTwid | \


Quotes (and other JS escapes) in TWID titles are still going to show up wrong.

adamdruppe · 2017-06-27T14:00:02Z

http://arsdnet.net/this-week-in-d/twid_latest.dd

wilzbach · 2017-06-27T18:30:55Z

Thanks a lot @adamdruppe! Integrated & rebased. Anything else missing? :)

wilzbach · 2017-06-27T18:31:56Z

For reference, this is how it currently looks:

CyberShadow · 2017-06-27T18:33:18Z

Looks great!

wilzbach · 2017-06-27T18:58:34Z

And fetching the latest resources on the deploy for dlang.org worked - it's live now :)

Thanks a lot @adamdruppe @mdparker @ZombineDev @aG0aep6G @CyberShadow !

@adamdruppe dlang.org gets built and deployed everytime a PR gets merged to dlang/{dmd,druntime,phobos,dlang.org} - according to your stats that's about 30 times a week or ~ three times a day. So, in the worst case, there might be a lag of a few hours until new articles are propagated on dlang.org.

CyberShadow · 2017-06-27T19:00:15Z

If you want, I can add a trigger that forces a rebuild

adamdruppe · 2017-06-27T19:01:30Z

On Tue, Jun 27, 2017 at 11:58:35AM -0700, Sebastian Wilzbach wrote: @adamdruppe dlang.org gets built and deployed everytime a PR gets merged to dlang/{dmd,druntime,phobos,dlang.org}

There's a lag with me updating it too, some days I don't get around to it till late monday, so not a big deal.

PetarKirov previously requested changes Jun 15, 2017

View reviewed changes

wilzbach force-pushed the show-latest-dblog branch from e0cf7d9 to 669d49c Compare June 15, 2017 14:48

wilzbach force-pushed the show-latest-dblog branch 2 times, most recently from ae2bd8c to 13c53d2 Compare June 16, 2017 01:25

wilzbach force-pushed the show-latest-dblog branch from 13c53d2 to 09a00b3 Compare June 18, 2017 23:45

CyberShadow reviewed Jun 19, 2017

View reviewed changes

wilzbach force-pushed the show-latest-dblog branch from 5de43ee to 4649c60 Compare June 19, 2017 00:10

wilzbach commented Jun 19, 2017

View reviewed changes

wilzbach force-pushed the show-latest-dblog branch from 4649c60 to 78589cb Compare June 19, 2017 00:25

wilzbach force-pushed the show-latest-dblog branch from 78589cb to c408e76 Compare June 19, 2017 00:32

wilzbach force-pushed the show-latest-dblog branch from c408e76 to b29ca60 Compare June 27, 2017 05:05

wilzbach force-pushed the show-latest-dblog branch from b29ca60 to d3df255 Compare June 27, 2017 05:06

CyberShadow reviewed Jun 27, 2017

View reviewed changes

wilzbach force-pushed the show-latest-dblog branch from d3df255 to c99aac3 Compare June 27, 2017 18:30

wilzbach added 2 commits June 27, 2017 20:30

Show latest article of the DBlog on the frontpage

5e045d7

Add banner to DConf2017

c99aac3

CyberShadow approved these changes Jun 27, 2017

View reviewed changes

CyberShadow added the auto-merge label Jun 27, 2017

dlang-bot merged commit 1dbd072 into dlang:master Jun 27, 2017

wilzbach deleted the show-latest-dblog branch June 27, 2017 18:48

		@@ -0,0 +1,213 @@
		<?xml version="1.0" encoding="UTF-8" standalone="no"?>

Uh oh!

Show latest article of the DBlog on the frontpage #1710

Show latest article of the DBlog on the frontpage #1710

Uh oh!

Conversation

wilzbach commented Jun 15, 2017

Uh oh!

PetarKirov Jun 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Jun 15, 2017

Uh oh!

adamdruppe commented Jun 15, 2017

Uh oh!

PetarKirov commented Jun 15, 2017

Uh oh!

wilzbach commented Jun 15, 2017

Uh oh!

aG0aep6G commented Jun 15, 2017

Uh oh!

CyberShadow commented Jun 15, 2017

Uh oh!

wilzbach commented Jun 16, 2017

Uh oh!

CyberShadow commented Jun 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilzbach commented Jun 18, 2017

Uh oh!

CyberShadow commented Jun 18, 2017

Uh oh!

wilzbach commented Jun 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach Jun 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Jun 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CyberShadow commented Jun 19, 2017

Uh oh!

CyberShadow commented Jun 19, 2017

Uh oh!

wilzbach commented Jun 19, 2017

Uh oh!

dlang-bot commented Jun 27, 2017

Bugzilla references

Uh oh!

wilzbach commented Jun 27, 2017

Uh oh!

CyberShadow commented Jun 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamdruppe commented Jun 27, 2017

Uh oh!

wilzbach commented Jun 27, 2017

Uh oh!

wilzbach commented Jun 27, 2017

Uh oh!

CyberShadow commented Jun 27, 2017

Uh oh!

wilzbach commented Jun 27, 2017

Uh oh!

PetarKirov Jun 15, 2017 •

edited

Loading

CyberShadow commented Jun 17, 2017 •

edited

Loading

wilzbach Jun 27, 2017 •

edited

Loading

wilzbach commented Jun 19, 2017 •

edited

Loading