Skip to content

Conversation

@Bolpat
Copy link
Contributor

@Bolpat Bolpat commented Jun 4, 2025

The most notable change is “Expressions may not reference any global or local static variables” to “Expressions may not reference any mutable static variables”. That is because immutable static variables are fine (in theory and practice) and it doesn’t matter where the static variable is declared.

The other notable change is from “The function must have a SpecifiedFunctionBody.” to “The function must have a FunctionBody.” That is because it is in fact a FunctionBody that’s required (in theory and practice).

Everything else is just wording and typography.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@thewilsonator thewilsonator merged commit dbb992a into dlang:master Jun 6, 2025
1 check passed
@Bolpat Bolpat deleted the patch-2 branch June 16, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants