importc: Add .h files to list of ImportC file extensions #4291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuclaw
requested review from
WalterBright,
andralex,
maxhaton and
mdparker
as code owners
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
0xEAB
reviewed
Aug 17, 2025
Member
Author
|
@thewilsonator ping. |
thewilsonator
approved these changes
Aug 19, 2025
| relative to the module that imports them.) | ||
|
|
||
| $(IMPLEMENTATION_DEFINED | ||
| $(OL |
Contributor
There was a problem hiding this comment.
How is this passing? where is the corresponding closing )?
Member
Author
There was a problem hiding this comment.
@thewilsonator you merged the bad code previously.
Contributor
There was a problem hiding this comment.
Using OL rather than UL does look a bit odd for only one item:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.