Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@MartinNowak
Copy link
Member

  • add filename functions to core.runtime
  • fix null terminated string
  • add tests

@MartinNowak MartinNowak force-pushed the profilegc branch 4 times, most recently from 04ae7c0 to 5d75d7b Compare August 29, 2015 10:12
@MartinNowak
Copy link
Member Author

Updated to fix all 32/64 bit issues and with changelog entry. Please merge for 2.068.1 beta.

@MartinNowak
Copy link
Member Author

Ping, beta is due today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be changed to camel casing before going into a release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not repeat the discussion #1225 (comment).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions are already used, so we cannot simply rename them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that the wrappers should at least use the proper druntime naming convention, but I accept that @WalterBright does not give a damn about having a consistent library experience, so feel free to merge. I strongly believe, also based on my personal experience, that inconsistent names are like – wait for it – barnacles on the bottom of a ship (this will make sense to those DConf attendees who stayed at the Hampton Inn). Too many of them, and a library slowly becomes unusable without constantly staring at the documentation.

MartinNowak added a commit that referenced this pull request Sep 2, 2015
@MartinNowak MartinNowak merged commit ba9ea9e into dlang:stable Sep 2, 2015
@MartinNowak MartinNowak deleted the profilegc branch September 2, 2015 04:52
@MartinNowak
Copy link
Member Author

I'm not too happy with the naming and Walter's disinterest in consistency myself, but those are rarely used functions so you'd likely have to look them up in the docs anyhow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants