-
-
Notifications
You must be signed in to change notification settings - Fork 413
follow up for -profile=gc #1359
Conversation
MartinNowak
commented
Aug 26, 2015
- add filename functions to core.runtime
- fix null terminated string
- add tests
04ae7c0 to
5d75d7b
Compare
|
Updated to fix all 32/64 bit issues and with changelog entry. Please merge for 2.068.1 beta. |
|
Ping, beta is due today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be changed to camel casing before going into a release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not repeat the discussion #1225 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functions are already used, so we cannot simply rename them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that the wrappers should at least use the proper druntime naming convention, but I accept that @WalterBright does not give a damn about having a consistent library experience, so feel free to merge. I strongly believe, also based on my personal experience, that inconsistent names are like – wait for it – barnacles on the bottom of a ship (this will make sense to those DConf attendees who stayed at the Hampton Inn). Too many of them, and a library slowly becomes unusable without constantly staring at the documentation.
|
I'm not too happy with the naming and Walter's disinterest in consistency myself, but those are rarely used functions so you'd likely have to look them up in the docs anyhow. |