Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@WalterBright
Copy link
Member

Blocking dlang/dmd#5860

@andralex andralex merged commit 49f9d5d into dlang:master Aug 10, 2016
@dnadlinger
Copy link
Contributor

This is a bit of a nonsensical change – the code can't possibly be @safe, since it uses a pointer/length API. bytesHash is mistakenly marked as trusted. Rather than entertaining this any further, it would have been better just to remove @safe from the unit test.

@WalterBright
Copy link
Member Author

@klickverbot You're right, I'll look into a revision. But in the meantime, this is no longer a blocker.

@WalterBright WalterBright deleted the hash-safe branch August 10, 2016 19:43
@dnadlinger
Copy link
Contributor

I generally agree with short-term fixes to get blockers out of the way, but not if the proper fix takes exactly the same amount of effort. :)

@WalterBright
Copy link
Member Author

#1627

@dnadlinger
Copy link
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants