Add isType to phobos.sys.traits. #10663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple and straightforward trait. It just says whether the template argument is a type or not. It has the same functionality as the trait with the same name in std.traits. However, the implementation is different. The std.traits version just has an alias overload and uses an is expression, whereas it seemed like it would probably be more efficient to split the trait into two and have the kind of argument determine the result, since the compiler has to go through the work of deciding whether the argument matches already, though I don't know enough about the compiler implementation to know for sure that this implementation is better. Either way, it can be changed later if it's determined that the std.traits implementation is better.
Contributor
|
Thanks for your pull request, @jmdavis! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#10663" |
thewilsonator
approved these changes
Mar 8, 2025
vpanteleev-sym
pushed a commit
to vpanteleev-sym/phobos
that referenced
this pull request
Jun 5, 2025
This is a simple and straightforward trait. It just says whether the template argument is a type or not. It has the same functionality as the trait with the same name in std.traits. However, the implementation is different. The std.traits version just has an alias overload and uses an is expression, whereas it seemed like it would probably be more efficient to split the trait into two and have the kind of argument determine the result, since the compiler has to go through the work of deciding whether the argument matches already, though I don't know enough about the compiler implementation to know for sure that this implementation is better. Either way, it can be changed later if it's determined that the std.traits implementation is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple and straightforward trait. It just says whether the template argument is a type or not. It has the same functionality as the trait with the same name in std.traits. However, the implementation is different. The std.traits version just has an alias overload and uses an is expression, whereas it seemed like it would probably be more efficient to split the trait into two and have the kind of argument determine the result, since the compiler has to go through the work of deciding whether the argument matches already, though I don't know enough about the compiler implementation to know for sure that this implementation is better. Either way, it can be changed later if it's determined that the std.traits implementation is better.