Tweak std.internal.scopebuffer docs #5027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix ddoc for commented out `this(this)` showing in `put`'s docs. * Fix missing ddoc for `put(CT[])` due to private `CT`. * Use documented unittest for scopeBuffer instead of inline code.
| /**************************** | ||
| * Copying of ScopeBuffer is not allowed. | ||
| */ | ||
| //@disable this(this); |
Contributor
There was a problem hiding this comment.
Why not just delete the docs and the commented out code here
| * $(D const(T)[]) as input. It will accept a $(D T[]) otherwise. | ||
| */ | ||
| private alias CT = Select!(is(const(T) : T), const(T), T); | ||
| package alias CT = Select!(is(const(T) : T), const(T), T); |
Contributor
Author
There was a problem hiding this comment.
CT has the docs for the following put, which uses ditto. As CT is private, ddoc ignores its docs and the ditto makes put(CT[]) ditto the first overload of put. (Maybe ddoc could be changed to be more helpful here).
Contributor
|
Auto-merge toggled on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reallocparameter.this(this)concatenated intoput's docs.put(CT[])due to privateCT.