std.math.lrint: Implement for 128 bit reals #5444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
dnadlinger
force-pushed
the
quad-lrint
branch
3 times, most recently
from
51ac9bc to
5a6861f
Compare
|
Requires #5445 to be correct. |
std/math.d
Outdated
| } | ||
| else | ||
| { | ||
| static assert(false, "Only 64-bit and 80-bit reals are supported by lrint()"); |
There was a problem hiding this comment.
Perhaps update this error message as well?
Verified on LDC/AArch64.
ibuclaw
approved these changes
Jun 7, 2017
They are. (The names are actually a bit misleading, they are the most- and least-significant halves of the type.) |
|
Auto-merging as Iain approved the change and this doesn't concern x86 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified on LDC/AArch64.
Similar to other implementations, adapted for wide case.