Skip to content

Update Phobos's DScanner to 0.5.0 #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2018
Merged

Update Phobos's DScanner to 0.5.0 #6412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb7c937
Revert dscanner. prefix
wilzbach Apr 3, 2018
a9f77c4
Bump DScanner to 0.5.0
wilzbach Apr 3, 2018
3feb6ae
Add the new trust_too_much DScanner check
wilzbach Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .dscanner.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
; Configure which static analysis checks are enabled
[dscanner.analysis.config.StaticAnalysisConfig]
[analysis.config.StaticAnalysisConfig]
; Check variable, class, struct, interface, union, and function names against
; the Phobos style guide
style_check="enabled"
Expand Down Expand Up @@ -95,6 +95,8 @@ has_public_example="enabled"
assert_without_msg="skip-unittest"
; Check indent of if constraints
if_constraints_indent="enabled"
; Check for @trusted applied to a bigger scope than a single function
trust_too_much="enabled"

; Configure which modules are checked with a specific checker
; Please help to extend these checks onto more Phobos modules
Expand All @@ -108,7 +110,7 @@ if_constraints_indent="enabled"
;
; Some checks are currently disabled.
; For more details, please see https://github.com/dlang/phobos/pull/5501
[dscanner.analysis.config.ModuleFilters]
[analysis.config.ModuleFilters]
; Check for uses of the old-style alias syntax
alias_syntax_check="-std.traits,-std.typecons"
; Check allman brace style
Expand Down Expand Up @@ -491,3 +493,5 @@ unused_variable_check="-std.algorithm.comparison,\
-std.zlib"
; Check for virtual calls in the class constructors
vcall_in_ctor="-std.socket,-std.xml"
; Check for @trusted applied to a bigger scope than a single function
trust_too_much="-std.math,-std.typecons,-std.regex,-std.stdio,-std.uni,-std.internal.cstring"
2 changes: 1 addition & 1 deletion posix.mak
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ ROOT_OF_THEM_ALL = generated
ROOT = $(ROOT_OF_THEM_ALL)/$(OS)/$(BUILD)/$(MODEL)
DUB=dub
TOOLS_DIR=../tools
DSCANNER_HASH=0ef3df1fd63371d9680348a5a45efd8675321ffc
DSCANNER_HASH=7b3542fb6aa5b0cca0552aedc5417211b17b3877
DSCANNER_DIR=$(ROOT_OF_THEM_ALL)/dscanner-$(DSCANNER_HASH)

# Set DRUNTIME name and full path
Expand Down